Open
Bug 326492
Opened 19 years ago
Updated 3 years ago
case insensitive match for *.manifest in nsChromeRegistry.cpp like made for *.js in nsPrefService.cpp
Categories
(Toolkit :: Startup and Profile System, enhancement)
Tracking
()
UNCONFIRMED
People
(Reporter: sherpya, Unassigned)
Details
Attachments
(1 file)
625 bytes,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
bug id 249335 it's expired but it can be closed since the "bug" (better to call a feature request) has been fixed in nsPrefService.cpp by using:
if (StringEndsWith(leafName, NS_LITERAL_CSTRING(".js"),
nsCaseInsensitiveCStringComparator())) {
I've made a patch that add the same comparator in:
chrome/src/nsChromeRegistry.cpp, since in the same environment
(winpe with all files uppercased) has the same problem had .js filename
check, just subst:
if (StringEndsWith(leafName, NS_LITERAL_CSTRING(".manifest"))) {
with
if (StringEndsWith(leafName, NS_LITERAL_CSTRING(".manifest"),
nsCaseInsensitiveCStringComparator())) {
Reproducible: Always
Steps to Reproduce:
1. Uppercase .manifest files in chrome directory
2.
3.
Actual Results:
The browser doesn't start at all it doesn't find needed resources
Expected Results:
start normally
Reporter | ||
Comment 1•19 years ago
|
||
Updated•19 years ago
|
Component: OS Integration → XRE Startup
Product: Firefox → Toolkit
QA Contact: os.integration → xre.startup
Version: unspecified → Trunk
Comment 2•19 years ago
|
||
You need to request a review (in this case from benjamin@smedbergs.us) to move forward with this patch.
BTW the expired thing is just a way to clear the system from old, inactive, and probably not useful reports to save some triager effort. If you still think that bug is valid (despite mike's comments), please feel free to reopen. It may still end up as wontfix, though.
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•