Logging code in child process takes significant amount time
Categories
(GeckoView Graveyard :: Sandboxing, defect, P2)
Tracking
(Performance Impact:high, firefox69 wontfix, firefox70 affected)
Performance Impact | high |
People
(Reporter: smaug, Unassigned, NeedInfo)
References
(Depends on 1 open bug, Blocks 1 open bug, Regression)
Details
(Keywords: perf:pageload, regression)
That is from a profile in bug 1543783
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Comes from chrome://geckoview/content/GeckoViewContentChild.js, chrome://geckoview/content/GeckoViewMediaChild.js, and chrome://geckoview/content/GeckoViewSelectActionChild.js
Comment 2•6 years ago
|
||
Perhaps logging is being forced-on? Not sure if this is GVE or fenix... probably gve
Comment 3•6 years ago
|
||
Logging is enabled in Nightly builds and FxR ships Nightly builds, so this is a real perf problem.
James says we should disable logging in Nightly builds and enable in local GV builds. Developers testing GV Nightly can re-enable logging with the geckoview.logging
pref. Randall added a new debugLogging
API (bug 1573304) to toggle logging.
I'll ask the perf team about disabling logging in local prefs for Nightly perf testing.
Comment 4•6 years ago
|
||
Jean, who is responsible for automation of the mobile performance benchmarks? GV has some logging code enabled by default that can cause some slowdowns. GV plans to disable the logging by default, but we have no ETA. In the meantime, we should add this geckoview.logging
pref to the list of prefs to set before running mobile performance benchmarks.
The default pref value is "Warn" in GV Release and Beta and "Debug" in GV Nightly:
The benchmark runner should probably set the geckoview.logging
pref to "Warn" (matching GV Release). Or should GV change its default to the quietest log level ("Fatal", I think)?
Updated•6 years ago
|
Comment 5•6 years ago
|
||
Fenix just landed code to disable GV logging in their release builds, but we should still fix GV's default for the benefit of other GV-powered apps like FxR.
Comment 6•4 years ago
|
||
We don't enable logging by default anymore, so this is not relevant.
Updated•4 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 7•3 years ago
|
||
Moving content process bugs to the new GeckoView::Sandboxing component.
Updated•1 year ago
|
Description
•