Closed
Bug 1208901
Opened 10 years ago
Closed 10 years ago
Fix a typo in nsStyleClipPath::nsStyleClipPath
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
994 bytes,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
Found by Viva64. Seems to have been a copy-paste error.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8666518 -
Flags: review?(cam)
Comment 3•10 years ago
|
||
FWIW, this code isn't tested or run without the layout.css.clip-path-shapes.enabled pref set, and in any case since we don't have an actual implementation of the feature yet (just the CSS parsing) just having the values listed in property_database.js isn't sufficient to check that we store the values in the nsStyleClipPath correctly.
I hear someone is (planning on?) working on CSS Masking (which I assume would encompass implementing the new clip-path values too) so hopefully we'll get test coverage from that soon.
Updated•10 years ago
|
Attachment #8666518 -
Flags: review?(cam) → review+
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ehsan
You need to log in
before you can comment on or make changes to this bug.
Description
•